Remove old mock generation logic, rename mocks --> stubs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbleyleSF
approved these changes
May 4, 2019
README.md
Outdated
|
|
||
| When this package is installed, a new set of mocks for all `lightning` namespaced components is generated into the `lightning-mocks` folder. These mocks are generated based off the `lwc-standard.json` metadata file. The mocks are auto-generated and the Jest resolver automatically uses these mocks in the tests. These work out-of-the-box, you don't need to do anything. | ||
| This package ships with stubs for the `lightning` base components. They are located in the `src/lightning-stubs` directory. These stubs will automatically get used when running tests through `lwc-jest`. You can override the default provided stub for your project by overriding the `moduleNameMapper` config as described below in the [Other Component Mocks](#other-component-mocks) section. |
There was a problem hiding this comment.
This package installs stubs for the lightning base components to the src/lightning-stubs directory. These stubs are used automatically when running tests through lwc-jest. To override the default stub provided for your project, override the moduleNameMapper config as described in Other Component Mocks.
README.md
Outdated
| @@ -108,7 +108,7 @@ lwc-jest --debug -- --no-cache | |||
| If you prefer to debug inside Visual Studio Code, follow these steps: | |||
| - From the Visual Studio Code dropdowns, select Debug > Add Configuration.... | |||
| - If you're prompted for an Environment choose any value. | |||
| - Replace the contents of the generated `launch.json` with the following. | |||
| - Replace the contents of the generated `launch.json` with the following (for Windows users see the [Jest website](https://jestjs.io/docs/en/troubleshooting#debugging-in-vs-code) for launch.json contents). | |||
There was a problem hiding this comment.
Mac users, replace the contents of the generated launch.json with the following. (Windows users, see the Jest website for launch.json contents).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate the stubs from an internal script now so the current metadatfile and script are outdated.
Also update the README.