Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ARIA attr/prop reflections #3693

Closed
nolanlawson opened this issue Aug 30, 2023 · 4 comments
Closed

Add missing ARIA attr/prop reflections #3693

nolanlawson opened this issue Aug 30, 2023 · 4 comments
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

Looking at the ARIAMixin spec and the aria* props available on Element.prototype in Chrome, there are a few we're missing.

Missing per Chrome:

  • ariaBrailleLabel
  • ariaBrailleRoleDescription
  • ariaDescription

Missing per the latest spec:

  • ariaColIndexText
  • ariaDescription
  • ariaRowIndexText

Once #3666 is released and we are out of the business of applying global polyfills, it should be safe to add these to the LightningElement/BaseBridgeElement prototypes. This will make it so that a template like:

<x-cmp aria-description="foo"></x-cmp>

...results in the ariaDescription prop (not attr) being set on x-cmp. This is consistent with what we currently do for most ARIA props, which allows for things like overriding the aria* getter/setter, plus convenience accessors like this.aria*.

Note: per Safari we are also missing the *Element/*Elements APIs, but since these are element reflection and not string reflection, we probably shouldn't do anything with these. Also we already have our non-standard string reflection for these:

  • ariaActiveDescendantElement
  • ariaControlsElements
  • ariaDescribedByElements
  • ariaDetailsElements
  • ariaErrorMessageElements
  • ariaFlowToElements
  • ariaLabelledByElements
  • ariaOwnsElements
@nolanlawson nolanlawson added enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation labels Aug 30, 2023
@jmsjtu jmsjtu mentioned this issue Sep 7, 2023
@MamataLV
Copy link
Contributor

MamataLV commented Sep 9, 2023

Hi @nolanlawson,
Is this issue open to fix? And can I work on this?

@nolanlawson
Copy link
Collaborator Author

@MamataLV Yes, but note some uncertainties: #3702 (comment)

@nolanlawson
Copy link
Collaborator Author

Firefox is shipping ARIA string reflection in Nightly. I just checked, and here are the props they support that we don't:

  • ariaColIndexText
  • ariaDescription
  • ariaRowIndexText

This matches the missing props from the spec.

@nolanlawson
Copy link
Collaborator Author

Fixed by #3702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

2 participants