Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve thread affinity at high thread count #42

Open
twarit-waikar opened this issue Jul 15, 2022 · 0 comments
Open

Improve thread affinity at high thread count #42

twarit-waikar opened this issue Jul 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@twarit-waikar
Copy link
Contributor

At high thread counts (over 500 or so), the CPU starts to get swamped with p4 calls, and it tends to starve the commit thread and causes it to not get any CPU time at all.

This means p4-fusion downloads all the files at first but it is really slow to digest those files and write them out into the repository while creating a commit. This essentially hangs the process.

High threads counts may even start losing connections because they were left idle for too long and so the Perforce server closed those connections.

p4-fusion should be smarter by giving more affinity to the commit thread and also, manage connections in a way that they are not closed off due to idle time. This means a new threadpool dispatch algorithm might be required.

@twarit-waikar twarit-waikar added the enhancement New feature or request label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant