Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use oclif.lock #134

Merged
merged 2 commits into from
Sep 11, 2023
Merged

feat: use oclif.lock #134

merged 2 commits into from
Sep 11, 2023

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Publish oclif.lock to lock deps during plugin install

What issues does this PR fix or reference?

@W-14071765@

@mdonnalley mdonnalley requested a review from a team as a code owner September 5, 2023 18:29
@git2gus
Copy link

git2gus bot commented Sep 5, 2023

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@@ -0,0 +1,3 @@
{
"exclude-scripts": ["prepack"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? The other PRs have not had this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin is on an old version of dev-scripts, which means that oclif lock is not part of the prepack script. I honestly didn't want to put in the effort to update to the latest dev-scripts so I decided to make the prepack script be sf-prepack && oclif lock" and then exclude prepackfromdev-scripts`'s management

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that makes sense, thanks

@iowillhoit iowillhoit merged commit db0d88e into main Sep 11, 2023
9 checks passed
@iowillhoit iowillhoit deleted the mdonnalley/oclif-lock branch September 11, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants