Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add no default and depends on flag configuration rule #440

Merged
merged 7 commits into from
Jul 22, 2024
Merged

feat: add no default and depends on flag configuration rule #440

merged 7 commits into from
Jul 22, 2024

Conversation

WillieRuemmele
Copy link
Contributor

@W-12356825@

image

cristiand391
cristiand391 requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above ⬆️

@cristiand391
Copy link
Member

QA notes:

setup:
build and installed eslint plugin as mentioned in the contributing doc, tested on plugin-data

✅ dependOn on flag with default value -> no error

✅ flag with default value, dependOn flag without default value -> lint error
✅ flag with default value, dependOn flag with default value -> no error
✅ flag with no default, dependOn flag with default value -> no error
✅ flag with no default, dependOn flag without default value -> no error

@WillieRuemmele
Wr/spread base flags (#441)
aa79026 
* feat: add only extend from SfCommand

* feat: add spread super command flags prop

* chore: update messages to include super class name

* chore: identify SfCommand parent class

* chore: move from error to warn on rollout

* chore: ..flags, ...baseFlags

* chore: update comment
@cristiand391 cristiand391 merged commit d4e7391 into main Jul 22, 2024
44 checks passed
@cristiand391 cristiand391 deleted the wr/noDefaultAndDependsOn branch July 22, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillieRuemmele @cristiand391