Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty strings to prevent unintended conversion to 0 #469

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 22, 2024

What does this PR do?

handle empty strings to prevent unintended conversion to 0

What issues does this PR fix or reference?

@W-14870382@

@mshanemc mshanemc added the bug Something isn't working label Jan 22, 2024
Copy link

git2gus bot commented Jan 22, 2024

This issue has been linked to a new work item: W-14870382

@mdonnalley mdonnalley merged commit 38b1a09 into main Jan 24, 2024
12 of 13 checks passed
@mdonnalley mdonnalley deleted the sm/handle-js-number-craziness branch January 24, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants