Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement an automated changelog #129

Merged
merged 3 commits into from
May 23, 2019
Merged

feat: implement an automated changelog #129

merged 3 commits into from
May 23, 2019

Conversation

daks
Copy link
Member

@daks daks commented May 18, 2019

Before removing 'draft' status and activate only 5 builds on Travis, I wanted to test them all: Fedora and OpenSuse fails, see https://travis-ci.com/daks/bind-formula/builds/112325721.
We need to see if we can/want to fix those platforms, remove them (in FORMULA, travis, kitchen, inspec) or just 'ignore' _ them.

TODO: reduce number of builds to 5 max

@myii
Copy link
Member

myii commented May 18, 2019

@daks Trying to compete with @n-rodriguez to see who can do the most semantic-release PRs, eh?! Maybe we should add the contributor to the docs so that we can keep track of the numbers!

@daks
Copy link
Member Author

daks commented May 19, 2019

@myii, not exactly, just trying to convert all formulas we use @ work :) And this conversion is generally not that much work... except when tests start failing...

@daks daks requested review from javierbertoli and myii May 19, 2019 07:32
myii
myii approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So other than the Travis instances, all OK from my end.

I saw some differences with template-formula but they aren't files touched by this PR. Fixed in #130 and #131.

@myii myii mentioned this pull request May 19, 2019
Open
71 tasks
@myii
Copy link
Member

myii commented May 19, 2019

@daks Of course, semantic-release isn't going to work unless all of the tests are passing, so need to ensure that that is working. It may be worth rebasing to use the latest Gemfile as well.

@daks
Copy link
Member Author

daks commented May 20, 2019

previous tests working: debian-8, debian-9, ubuntu-16.04, ubuntu-18.04, fedora-27 and centos-7 on latest salt

@daks
Copy link
Member Author

daks commented May 21, 2019 •
edited
Loading

I don't understand why those tests are failing. Provisioning (states, pillars) should be the same, and tests too

@daks daks force-pushed the semantic-release branch 8 times, most recently from 25be4b6 to cc3e838 Compare May 22, 2019 13:39
@daks
Copy link
Member Author

daks commented May 22, 2019

I have fixed most of Suse/OpenSuse tests. The only one remaining is weird https://travis-ci.com/daks/bind-formula/jobs/202183367 -> inspec don't find 'named' service running, while it is

About Fedora, I can't fix them because they 'work on my laptop'(TM). any help would be appreciated.

@daks daks marked this pull request as ready for review May 22, 2019 13:59
@javierbertoli
Copy link
Member

I have fixed most of Suse/OpenSuse tests. The only one remaining is weird https://travis-ci.com/daks/bind-formula/jobs/202183367 -> inspec don't find 'named' service running, while it is

It's quite probably the same issue due to the train gem

Perhaps you can skip it atm.

@daks
Copy link
Member Author

daks commented May 22, 2019 •
edited
Loading

@javierbertoli ok, I'll skip opensuse 15 for now.

Still Fedora failing.

@myii
Copy link
Member

myii commented May 22, 2019

@daks Or you could use @n-rodriguez's fix here appended in the Gemfile:

gem 'train', git: 'https://github.com/n-rodriguez/train.git', branch: 'wip/fix_suse'

@daks
Copy link
Member Author

daks commented May 23, 2019

Tests matrix reduced to 4 platforms

@myii
Copy link
Member

myii commented May 23, 2019

@daks Do you want this merged now?

@daks
Copy link
Member Author

daks commented May 23, 2019

If it's OK for everybody, yes.

@myii myii merged commit 70e9ed0 into saltstack-formulas:master May 23, 2019
@myii
Copy link
Member

myii commented May 23, 2019

Merged, thanks for another big PR, @daks.

@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii mentioned this pull request Jun 28, 2019
Merged
saltstack-formulas-travis pushed a commit that referenced this pull request Aug 17, 2019
@semantic-release-bot
chore(release): 0.18.0 [skip ci]
879ad8e 
# [0.18.0](v0.17.0...v0.18.0) (2019-08-17)

### Continuous Integration

* **kitchen+travis:** modify matrix to include `develop` platform ([641e641](641e641)), closes [#129](#129)

### Features

* **yamllint:** include for this repo and apply rules throughout ([a81c9ff](a81c9ff))
@myii myii mentioned this pull request Aug 18, 2019
Merged
@myii myii mentioned this pull request Mar 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

@javierbertoli javierbertoli Awaiting requested review from javierbertoli javierbertoli is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daks @myii @javierbertoli @saltstack-formulas-travis