Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableexcludes to states.pkg #25617

Closed
seanjnkns opened this issue Jul 22, 2015 · 8 comments
Closed

Add disableexcludes to states.pkg #25617

seanjnkns opened this issue Jul 22, 2015 · 8 comments
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around stale State-Module
Milestone

Comments

@seanjnkns
Copy link
Contributor

Per issue #11415, this was added into yumpkg. If doing any yum exclusion enforcement, states will fail when trying to install anything that was excluded. It's preferable to add disableexcludes to the states.pkg vs. having no exclusions and then doing holds on most versions of packages on the system or doing something similar to this:

httpd:
  pkg.installed:
    - hold: True
    - version: {{ httpd_version }}
    - cmd.run:
      - name: yum install --disableexcludes=all httpd

IMO, disableexcludes should not be set unless specifically included.

@jfindlay jfindlay added State-Module Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around help-wanted Community help is needed to resolve this P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps Execution-Module and removed State-Module labels Jul 22, 2015
@jfindlay jfindlay added this to the Approved milestone Jul 22, 2015
@jfindlay
Copy link
Contributor

@seanjnkns, thanks for the report.

@seanjnkns
Copy link
Contributor Author

I fail to see how #29707 addresses any part of this issue/feature request. What I'm recommending is something similar to this, assuming say httpd* was excluded in your /etc/yum.conf. I realize doesn't work for all distros:

httpd:
pkg.installed:

  • disableexcludes: True (default would be False)
    • version: {{ httpd_version }} (optional as it is now)

And this should just as easily be extended to pkgs, not just pkg, if there's a grouping and you want to ensure that exclusions are disabled for salt runs, but otherwise enforced. This then makes salt's salt.states.pkg.uptodate usable while not blindly updating everything, imo.

@abednarik
Copy link
Contributor

I made a mistake when linking this PR.

Sorry about that.

@afletch
Copy link
Contributor

afletch commented Mar 15, 2016

Since #11415 added this functionality to execution module yumpkg, there is now unexpected feature disparity between the pkg state and the yumpkg execution module. The labels of this issue should include state module, surely?

@kporembinski
Copy link

+1

When this feature will be added to states.pkg?

@stale
Copy link

stale bot commented Jul 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jul 1, 2018
@stale stale bot closed this as completed Jul 8, 2018
@tlemarchand
Copy link
Contributor

I think this is still needed.
Excludes are often used for Kubernetes deployments for example, to avoid unattended upgrades.

@hbayindir
Copy link

This feature is still needed like in Kubernetes installations as aforementioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around stale State-Module
Projects
None yet
Development

No branches or pull requests

7 participants