Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force=True documentation for RabbitmqUser is misleading #28974

Closed
belt-ascendlearning opened this issue Nov 17, 2015 · 3 comments
Closed

force=True documentation for RabbitmqUser is misleading #28974

belt-ascendlearning opened this issue Nov 17, 2015 · 3 comments
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists
Milestone
Approved

Comments

@belt-ascendlearning
Copy link

Reading the code, if the user exists, nothing will happen unless force=True is set... not just for passwords.
@belt-ascendlearning belt-ascendlearning mentioned this issue Nov 17, 2015
Closed
@jfindlay jfindlay added Execution-Module Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Nov 18, 2015
@jfindlay jfindlay added this to the Approved milestone Nov 18, 2015
@jfindlay jfindlay added the help-wanted Community help is needed to resolve this label Nov 18, 2015
@jfindlay
Copy link
Contributor

@belt-ascendlearning, is this on 2015.8.1?

@belt-ascendlearning
Copy link
Author

Yes.

@rallytime
Copy link
Contributor

@belt-ascendlearning Looking at the code history, on version 2015.8.1, that was definitely true. However, I updated that function to use test=true functionality with PR #28269, and during that change, force=True functionality now only affects password changes.

This is fixed in the 2015.8.3 release of Salt. Thanks for the report! I'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@jfindlay @rallytime @belt-ascendlearning