[master] Datetime utcnow #66902
Open
[master] Datetime utcnow #66902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
twangboy
approved these changes
Sep 18, 2024
twangboy
requested changes
Sep 18, 2024
marmarek
force-pushed
the
datetime-utcnow
branch
from
b2d27e1 to
332538e
Compare
Fixed |
|
Looks like the test failures are related to your changes in |
dmurphy18
previously approved these changes
Sep 18, 2024
What test failures? For the current version I don't see any (there are either green, or pending) |
|
The test suite tries 3 times... here is the 2nd run: |
marmarek
force-pushed
the
datetime-utcnow
branch
from
332538e to
5019ab1
Compare
|
Ah, I see, |
datetime.datetime.utcnow() is deprecated in Python 3.12, and it's recommended to switch to timezone-aware objects, so do this. It also simplifies local time handling, as .astimezone() method can be used instead of calculating timezone_delta manually. Part of saltstack#65604
marmarek
force-pushed
the
datetime-utcnow
branch
from
5019ab1 to
90454cc
Compare
twangboy
approved these changes
Sep 20, 2024
dmurphy18
approved these changes
Sep 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes some usage of deprecated datetime.datetime.utcnow() and replaces them with timezone-aware objects, while not changing the actual behavior.
What issues does this PR fix or reference?
Partial fix for #65604
This is complementary to #66042
Previous Behavior
Salt logs warnings like:
New Behavior
No warning.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.