Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint pre-commit #79

Open
samarsault opened this issue Jul 7, 2020 · 5 comments
Open

Lint pre-commit #79

samarsault opened this issue Jul 7, 2020 · 5 comments

Comments

@samarsault
Copy link
Owner

Add a git pre commit hook to run a lint fix.

@Devanshu24
Copy link
Collaborator

I had thought of this, but when I read on it I found that it is something that every user will have to configure on their own system (which doesn't help us much)
Or is there some other option as well, which works better?

@samarsault
Copy link
Owner Author

samarsault commented Jul 8, 2020

Yes, it has to be configured by each user. To make this easer, what we can do is:

  1. Provide the hook
  2. A command to link that to .git/hooks

@Devanshu24
Copy link
Collaborator

Oh okay, so in that case, the CI will always pass the linting test, right?
Then why don't we add a hook for the jest tests also,
Although the CI will be rendered almost immaterial...

@samarsault
Copy link
Owner Author

No, not all lint errors are fixed automatically. Plus, tests take more time to run as the number of tests increases.

@Devanshu24
Copy link
Collaborator

No, not all lint errors are fixed automatically.

Oh yes, right. I meant the commit won't happen until you fix all the errors right?

Plus, tests take more time to run as the number of tests increases.

Didn't fully understand, are you saying we won't have a hook for tests because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants