From 1ca9c7b4e52007734f44d74e0188da3b436a9cee Mon Sep 17 00:00:00 2001 From: mr <995672751@qq.com> Date: Thu, 18 Jul 2024 01:08:46 +0800 Subject: [PATCH] Update string.go (#496) * Update string.go more reasonable * test --- string.go | 2 +- string_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/string.go b/string.go index 6d66ca15..1d808788 100644 --- a/string.go +++ b/string.go @@ -58,7 +58,7 @@ func Substring[T ~string](str T, offset int, length uint) T { } } - if offset > size { + if offset >= size { return Empty[T]() } diff --git a/string_test.go b/string_test.go index e3d6eabf..50ccc8d9 100644 --- a/string_test.go +++ b/string_test.go @@ -76,6 +76,7 @@ func TestSubstring(t *testing.T) { str12 := Substring("hello", -4, math.MaxUint) str13 := Substring("🏠🐶🐱", 0, 2) str14 := Substring("你好,世界", 0, 3) + str15 := Substring("hello", 5, 1) is.Equal("", str1) is.Equal("", str2) @@ -91,6 +92,7 @@ func TestSubstring(t *testing.T) { is.Equal("ello", str12) is.Equal("🏠🐶", str13) is.Equal("你好,", str14) + is.Equal("", str15) } func TestRuneLength(t *testing.T) {