Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About trace and span #2

Open
samber opened this issue May 17, 2023 · 0 comments
Open

About trace and span #2

samber opened this issue May 17, 2023 · 0 comments

Comments

@samber
Copy link
Owner

samber commented May 17, 2023

I added support for Trace and Span which are ULID by default.

For now, Span are not exported from ToMap(), Format(), Marshal() and LogValuer. Is this expected and how should we format it?

2 options come to my mind:

  • add Span to each the stack trace and source fragments
  • return a list of Span from the .Span() getter (not very useful since there is no context provided to each Span)

Currently, the .Span() getter only returns the Span of the parent oops.OopsError. The Trace is generated lazily by the getter only if none was provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant