Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix: update commit status on merge error #7

Closed
wants to merge 1 commit into from
Closed

fix: update commit status on merge error #7

wants to merge 1 commit into from

Conversation

samcontesse
Copy link
Owner

also mark it as pending as soon as the get is triggered and failed
when other errors occur.

closes #5

fix: update commit status on merge error
836a0b0 
also mark it as `pending` as soon as the `get` is triggered and `failed`
when other errors occur.

closes #5
@SuperTux88
Copy link

So #5 is still a problem, but this was never merged, and has conflicts now. Is there a reason why this was never merged?

I thought that a workaround for #5 is to set skip_not_mergeable to true, so the merge should never fail. But that has other side-effects, as sometimes the mergeStatus is set to "unchecked" instead of "can_be_merged", because gitlab doesn't know yet if it's mergeable or not, so these MRs then sometimes end up never being built.

@samcontesse
Copy link
Owner Author

Closing since this repository is going to be archived.

@samcontesse samcontesse deleted the bugfix/failed-merge-commit-status branch July 29, 2024 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samcontesse @SuperTux88