Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ / Java colors for Enums #22

Open
pkt77 opened this issue Jun 1, 2020 · 5 comments
Open

IntelliJ / Java colors for Enums #22

pkt77 opened this issue Jun 1, 2020 · 5 comments
Labels
enhancement New feature or request highlighting

Comments

@pkt77
Copy link

pkt77 commented Jun 1, 2020

I was asked to post an issue here based on my review:

Great theme for Java, however I believe there should be a different color for enums like there is for interfaces. Currently they have the same color as classes and accessing an enum member uses the same color as a static variable.

I can go in more detail here.
image
The interface Map color is different from the Object color. I'd like a similar difference for Enums like LogLevel. I'm not really good with colors, but maybe lighter than objects since interfaces are darker?

I'd also like the color of enum accessed INFO to be different from statically accessed variables like MAX_VALUE - I'm not sure if this one is possible since they're both technically constants.

@samdark
Copy link
Owner

samdark commented Jun 2, 2020

Would you please provide some code snippets? I'll check how it's done in VS Code and what could be done in the theme. Thanks.

@samdark samdark added the enhancement New feature or request label Jun 2, 2020
@pkt77
Copy link
Author

pkt77 commented Jun 3, 2020

Do you mean code snippets in VS, or what else besides that image?

@samdark
Copy link
Owner

samdark commented Jun 3, 2020

Ah, sorry. Thought these are custom classes but these aren't. Haven't touched Java in more than 10 years :)

@samdark
Copy link
Owner

samdark commented Jun 10, 2020

That is how it looks in VS code:

image

@samdark
Copy link
Owner

samdark commented Jun 16, 2020

@pkt77 in case you've already adjusted it, it would be really helpful if you'll share your color scheme changes. See https://github.com/samdark/intellij-visual-studio-code-dark-plus/blob/master/.github/CONTRIBUTING.md#code-highlighting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request highlighting
Projects
None yet
Development

No branches or pull requests

2 participants