Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The color scheme is not consistent with VS Code. import Purple/pink color is missing. JavaScript React JS #39

Open
twilingway opened this issue Mar 19, 2021 · 6 comments

Comments

@twilingway
Copy link

twilingway commented Mar 19, 2021

What the issue is?

if i set Keywords in WS function, const var let also change color

Screenshots

https://yadi.sk/i/Cpx2IfUBuJB9Og
also component color wrong
https://yadi.sk/i/JRqC2BxpHUlRjw

How would you fix it?

Additional info

Q A
Plugin Version 2.3
IDE and version 2020.1
Operating system win 10
@twilingway twilingway changed the title The color scheme is not consistent with VS Code. import Purple/pink color is missing. The color scheme is not consistent with VS Code. import Purple/pink color is missing. JavaScript React JS Mar 19, 2021
@adrien-cuisse
Copy link

adrien-cuisse commented Mar 21, 2021

The problem is that PhpStorm puts all keywords in the same bag.

Here's a piece of code using VSCode, you can see conditions and return getting another highlight
image

The same piece of code on PhpStop
image

You can notice the isset having wrong color too (keyword for PhpStorm)

ArchLinux
Java 11
PhpStorm 2020.3
Plugin v1.4

@samdark
Copy link
Owner

samdark commented Mar 21, 2021

Yeah. Can not fix it until PhpStorm will see these as different types.

@dinbtechit
Copy link

dinbtechit commented Jul 6, 2021

Perhaps it's a good idea to have a separate plugin for PhpStorm? Or Having at least import(s) and return(s) highlighted as purple/pink would be cool :). Thoughts?

@samdark
Copy link
Owner

samdark commented Jul 6, 2021

@dinbtechit well, extra tokenizing could theoretically be done in this plugin but I doubt I currently have enough time to implement it.

@dinbtechit
Copy link

dinbtechit commented Aug 28, 2021

@samdark - I have time to work on this but having a hard time wrapping my head around how tokenizing works. Can you give me a basic example of how to create tokenization in this plugin?

Like you said, class, implementation, etc and import are in the same bucket keyword. Which makes impossible to change just the import's color without affecting other keyword's color. Is it possible to create a "sub-bucket" under the keyword. Sadly, JetBrain's documentation is very limited on this.

image

@samdark
Copy link
Owner

samdark commented Aug 30, 2021

@dinbtechit I'm not aware of it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants