Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree file selectionInactiveBackground is not obvious #58

Open
huo-feng-ding opened this issue Jul 7, 2023 · 6 comments
Open

Tree file selectionInactiveBackground is not obvious #58

huo-feng-ding opened this issue Jul 7, 2023 · 6 comments
Labels

Comments

@huo-feng-ding
Copy link

In left file tree , current inactive selection file selectionInactiveBackground color is not obvious

@samdark
Copy link
Owner

samdark commented Jul 7, 2023

What do you mean by "not obvious"? Would you please post a screenshot? Which color would you suggest?

@samdark samdark added the ui label Jul 7, 2023
@patrickteng
Copy link

patrickteng commented Jul 10, 2023

Screenshot 2023-07-10 at 10 14 01 AM

This is the old UI. the latest version is like this instead. Which makes it very very hard to notice the current active function

Screenshot 2023-07-10 at 10 15 46 AM

*Note, both screenshot is selecting the same function, namely, accounts().

I have to downgrade PHPStorm to 2023.1.2 then download VSC Dark Plus 2.7 to make it visible again (because 2.7 is not working with 2023.1.3).

@huo-feng-ding
Copy link
Author

very hard to find which one is current opened file

@samdark
Copy link
Owner

samdark commented Jul 10, 2023

That is consistent with how VSCode handles it but yeah, I agree that previous color usability-wise is better. I'll change it.

@iseeltf
Copy link

iseeltf commented Sep 9, 2024

That is consistent with how VSCode handles it but yeah, I agree that previous color usability-wise is better. I'll change it.

@samdark I really like the theme provided by this plugin, and looking forward to further optimizations on this issue.
image

@samdark
Copy link
Owner

samdark commented Sep 9, 2024

@iseeltf would be great if you'll help with a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants