Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with parens at end of SQL #3

Open
cthompsonim opened this issue Jul 12, 2019 · 1 comment
Open

Issue with parens at end of SQL #3

cthompsonim opened this issue Jul 12, 2019 · 1 comment
Labels

Comments

@cthompsonim
Copy link

in displaySummary the $token = trim($token, '()'); line is heavy-handed in that it will truncate legitimate parens at the end of an SQL statement that is not terminated by a semicolon.

SELECT This FROM That WHERE ((A=B) AND (C=D))

Will produce

SELECT This FROM That WHERE ((A=B) AND (C=D

On the other side of the call which, if used in copy/paste, or run through something like sqlFormatter, will produce errors.

@samdark samdark added the bug label Jul 12, 2019
@samdark
Copy link
Owner

samdark commented Jul 12, 2019

Looks valid. Do you want to do pull request fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants