-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupt "mp3" audio is really webm #54
Comments
@theDanielJLewis - That is strange, this is something I had thoroughly tested. Thanks for bringing this up though. |
I guess I was wrong in assuming the downloaded files actually are |
I'm guessing it's simply because that's how modern browsers now capture audio. That I now know it records only in webm means I can find a way to handle the conversion to MP3. In my use case, the audio will be downloaded by someone other than the person who records it. |
Ah, I see. Sorry for the trouble caused. |
Fixed by Pull request #59 |
@samhirtarif can you include an example of how to make say my website built in say Next JS, cross-origin isolated? |
https://vercel.com/guides/fix-shared-array-buffer-not-defined-nextjs-react |
there is a bug in the package. whenever i used recorderControls prop on the AudioRecorder component then while recording when i want to discard the recording, it just uploads it instead of discarding it, so i think this need to be solved |
Using the sample code, when I set
downloadFileExtension="mp3"
, something is downloaded with a.mp3
file extension, but it's not an MP3. Attempting to play it yields only a loud corrupt sound.The file is actually still a
.webm
and changing the extension to.webm
makes it playable.So what's the point of setting the extension to MP3 or WAV if it doesn't actually give an MP3 or WAV? Or is this simply broken?
The text was updated successfully, but these errors were encountered: