Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Interning of Complex Types #725

Merged
merged 1 commit into from
May 31, 2022
Merged

Improve Interning of Complex Types #725

merged 1 commit into from
May 31, 2022

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented May 26, 2022

All explicit modelled complex types will intern if they consist only of interned extensions. This will save memory for complex types tagged with a data absent reason extension.

Also some optimizations regarding encoding of resources as JSON were done in order to preserve encoding times reached before implementing extended primitive types.

@alexanderkiel alexanderkiel self-assigned this May 26, 2022
@alexanderkiel alexanderkiel added the performance Performance improvement label May 26, 2022
@alexanderkiel alexanderkiel added this to the v0.17.6 milestone May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #725 (b9311da) into develop (7269601) will increase coverage by 0.02%.
The diff coverage is 86.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #725      +/-   ##
===========================================
+ Coverage    93.56%   93.58%   +0.02%     
===========================================
  Files          230      232       +2     
  Lines        14102    14226     +124     
  Branches       384      386       +2     
===========================================
+ Hits         13194    13314     +120     
- Misses         524      526       +2     
- Partials       384      386       +2     
Impacted Files Coverage Δ
...r-structure/src/blaze/fhir/spec/type/protocols.clj 100.00% <ø> (ø)
.../blaze/fhir/operation/evaluate_measure/measure.clj 95.16% <ø> (ø)
.../fhir-structure/src/blaze/fhir/spec/impl/specs.clj 87.50% <66.66%> (-0.66%) ⬇️
...odules/fhir-structure/src/blaze/fhir/spec/type.clj 86.94% <67.85%> (-0.61%) ⬇️
...odules/fhir-structure/src/blaze/fhir/spec/impl.clj 95.89% <81.25%> (+0.24%) ⬆️
...fhir-structure/src/blaze/fhir/spec/type/macros.clj 99.50% <98.79%> (-0.50%) ⬇️
...s/fhir-structure/src/blaze/fhir/spec/impl/util.clj 100.00% <100.00%> (+7.69%) ⬆️
...es/fhir-structure/src/blaze/fhir/spec/impl/xml.clj 100.00% <100.00%> (ø)
...s/fhir-structure/src/blaze/fhir/spec/type/json.clj 100.00% <100.00%> (ø)
.../operation/evaluate_measure/measure/stratifier.clj 88.99% <100.00%> (+0.10%) ⬆️
... and 3 more

@alexanderkiel alexanderkiel force-pushed the fhir-structure branch 4 times, most recently from e6660f4 to 80faaeb Compare May 30, 2022 20:29
All explicit modeled complex types will intern if they consist only of
interned extensions. This will save memory for complex types tagged with
a data absent reason extension.

Also some optimizations regarding encoding of resources as JSON were
done in order to preserve encoding times reached before implementing
extended primitive types.
@alexanderkiel alexanderkiel merged commit 57f66c0 into develop May 31, 2022
@alexanderkiel alexanderkiel deleted the fhir-structure branch May 31, 2022 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant