diff --git a/OTLPView/DataModel/Common.cs b/OTLPView/DataModel/Common.cs index dfe528e..53ce3cb 100644 --- a/OTLPView/DataModel/Common.cs +++ b/OTLPView/DataModel/Common.cs @@ -57,7 +57,6 @@ public string ShortApplicationName public MeterResult GetOrAddMeter(string meterName, Func itemFactory) => _meters.GetOrAdd(meterName, _ => itemFactory.Invoke(meterName)); #endregion - #region Traces private readonly ConcurrentDictionary _scopes = new(); @@ -65,23 +64,4 @@ public string ShortApplicationName public TraceScope GetOrAddTrace(string scopeName, Func itemFactory) => _scopes.GetOrAdd(scopeName, _ => itemFactory.Invoke(scopeName)); #endregion - - - - -} - -public static class CommonHelpers -{ - public static string GetServiceId(this Resource resource) - { - foreach (var attribute in resource.Attributes) - { - if (attribute.Key == OtlpApplication.SERVICE_INSTANCE_ID) - { - return attribute.Value.ValueString(); - } - } - return null; - } } diff --git a/OTLPView/Extensions/Helpers.cs b/OTLPView/Extensions/Helpers.cs index 3ab841b..6beadb1 100644 --- a/OTLPView/Extensions/Helpers.cs +++ b/OTLPView/Extensions/Helpers.cs @@ -2,6 +2,12 @@ namespace OTLPView.Extensions; public static class Helpers { + public static string? GetServiceId(this Resource resource) => + resource.Attributes + .FirstOrDefault(attr => attr.Key == OtlpApplication.SERVICE_INSTANCE_ID) + ?.Value + .ValueString(); + public static bool FindStringValue(this RepeatedField attributes, string key, out string? value) { value = null; diff --git a/OTLPView/Pages/Metrics.razor.cs b/OTLPView/Pages/Metrics.razor.cs index 1287b88..9a4ccc1 100644 --- a/OTLPView/Pages/Metrics.razor.cs +++ b/OTLPView/Pages/Metrics.razor.cs @@ -83,6 +83,9 @@ public string IsMetricSelected(Counter o, string cssClass) => public void SelectedCounterChanged(object item) { - State.SelectedMetric = item as Counter; + if (item is Counter counter) + { + State.SelectedMetric = counter; + } } } diff --git a/OTLPView/Shared/DimensionedCounterView.razor.cs b/OTLPView/Shared/DimensionedCounterView.razor.cs index 70ad312..b67f1bf 100644 --- a/OTLPView/Shared/DimensionedCounterView.razor.cs +++ b/OTLPView/Shared/DimensionedCounterView.razor.cs @@ -6,8 +6,8 @@ public sealed partial class DimensionedCounterView private string[] chartLabels; private List chartValues; - [Parameter] - public DimensionScope Dimension + [Parameter, EditorRequired] + public required DimensionScope Dimension { get => _dimension; set @@ -24,8 +24,8 @@ public DimensionScope Dimension } } - [Parameter] - public Counter Counter { get; set; } + [Parameter, EditorRequired] + public required Counter Counter { get; set; } protected override void OnInitialized() { @@ -51,12 +51,14 @@ private double[] CalcChartValues(DimensionScope dimension) var end = CalcOffset(point.End); if (start is not null && end is not null) { - for (int i = start.GetValueOrDefault(0); i <= end.GetValueOrDefault(17); i++) + for (var i = start.GetValueOrDefault(0); i <= end.GetValueOrDefault(17); i++) { - if (point as MetricValue != null) - { values[i] = Math.Max((point as MetricValue).Value, values[i]); } - else - { values[i] = Math.Max((point as MetricValue).Value, values[i]); } + values[i] = point switch + { + MetricValue @longMetric => Math.Max(@longMetric.Value, values[i]), + MetricValue doubleMetric => Math.Max(doubleMetric.Value, values[i]), + _ => values[i] + }; } } } diff --git a/OTLPView/Shared/DimensionedHistogramView.razor b/OTLPView/Shared/DimensionedHistogramView.razor index caa0096..bcf6375 100644 --- a/OTLPView/Shared/DimensionedHistogramView.razor +++ b/OTLPView/Shared/DimensionedHistogramView.razor @@ -13,13 +13,13 @@ @if (mValue is HistogramValue) { var hValue = mValue as HistogramValue; -
- Count: - @hValue.Count - Sum: - @hValue.Sum - Buckets: - @if (hValue.Values is not null) +
+ Count: + @hValue.Count + Sum: + @hValue.Sum + Buckets: + @if (hValue.Values is not null) { foreach (var v in hValue.Values) { @@ -32,14 +32,11 @@ { @mValue.ToString() } - }
@code { - [Parameter] - public DimensionScope Dimension { get; set; } - - + [Parameter, EditorRequired] + public required DimensionScope Dimension { get; set; } } diff --git a/OTLPView/Shared/TraceSpanView.razor b/OTLPView/Shared/TraceSpanView.razor index 5a65f35..3d0fc7c 100644 --- a/OTLPView/Shared/TraceSpanView.razor +++ b/OTLPView/Shared/TraceSpanView.razor @@ -13,8 +13,6 @@
- - @foreach (var s in Span.ChildSpans) {