Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsJson(*) and IsUUID(*) reprs can't be evaluated #82

Open
alexmojaki opened this issue Sep 16, 2023 · 2 comments · May be fixed by #109
Open

IsJson(*) and IsUUID(*) reprs can't be evaluated #82

alexmojaki opened this issue Sep 16, 2023 · 2 comments · May be fixed by #109

Comments

@alexmojaki
Copy link
Contributor

Why is repr(IsJson()) == 'IsJson(*)'? I think 'IsJson()' is a perfectly clear repr, and it follows the convention that eval(repr(x)) is equivalent to x. I also think seeing IsJson(*) in a diff would be confusing and distracting.
@samuelcolvin
Copy link
Owner

Fair, happy to remove it.

@alexmojaki
Copy link
Contributor Author

Great, I'm doing some repr related stuff so I'll take care of that. While I'm at it, can I change repr(IsApprox(42)) to IsApprox(42) instead of IsApprox(approx=42)? The latter seems redundant.

@FBruzzesi FBruzzesi linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: IsJson and IsUUID repr FBruzzesi/dirty-equals
2 participants
@alexmojaki @samuelcolvin