Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming a dir hides its contents #71

Closed
menaquinoneK2 opened this issue Jun 24, 2020 · 2 comments
Closed

renaming a dir hides its contents #71

menaquinoneK2 opened this issue Jun 24, 2020 · 2 comments
Labels
Status: Fixed in Next Build Fixed in the next Sandboxie version ToDo To be done Type: Bug Something isn't working Type: File Operations Copy, move, delete, and rename files/folders

Comments

@menaquinoneK2
Copy link

menaquinoneK2 commented Jun 24, 2020

  1. Create a dir on host eg. c:\1
  2. Create a file(or dir!) inside the c:\1 dir, eg. echo a>a
  3. open explorer inside the sandbox
  4. look inside c:\1, you see file a
  5. go back out and rename 1 to 2
  6. go inside 2, there's no a file anymore

now, rename it back from 2 to 1 and contents are back
if you made something new in 2, then after renaming 2 to 1 their contents are now seen as merged

@DavidXanatos
Copy link
Member

bugs bugs everyware....

When I try the same thing with the registry editor I cant rename a key that exists on the host also not good

but how to fix that... I mean
a) create a full copy on rename
b) store some metadata indicating the new name

I think we should go with B even though its more work

@DavidXanatos DavidXanatos added the ToDo To be done label Aug 8, 2021
@DavidXanatos DavidXanatos added Type: File Operations Copy, move, delete, and rename files/folders Status: Fixed in Next Build Fixed in the next Sandboxie version labels Jan 22, 2022
@DavidXanatos
Copy link
Member

This fix is ready and will be added in one of the upcoming builds, may be not the next as that might be only a minor release with some fixes only quickly followed by a large experimental release
this feature will need you to enable it with UseFileDeleteV2=y

Also I haven't yet sorted out the handling of snapshots not sure if that will be done till the release.

With this change sandboxie will no longer create dummy deletion mark files/folders, instead it will maintain a data file of deleted and also of renamed paths.

Also currently renaming a file always creates a boxed copy, in a later stage that could be improved to use the same relocation mechanism as will be now used for folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Fixed in Next Build Fixed in the next Sandboxie version ToDo To be done Type: Bug Something isn't working Type: File Operations Copy, move, delete, and rename files/folders
Projects
None yet
Development

No branches or pull requests

2 participants