Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickles are Bad, JSON is Good #446

Open
coreyostrove opened this issue May 31, 2024 · 0 comments
Open

Pickles are Bad, JSON is Good #446

coreyostrove opened this issue May 31, 2024 · 0 comments
Labels
enhancement Request for a new feature or a change to an existing feature low priority Developers should be aware of this issue, but it need not be addressed imminently
Milestone

Comments

@coreyostrove
Copy link
Contributor

While it happens that I also dislike pickles of the cucumber variety, I am of course referring to serialized objects produced using the pickle module. The issue is often due to backwards compatibility issues that arise that make it very difficult to unpickle things produced using prior versions of pygsti in the newest environment. This is all stuff that we know already, and was the impetus for spinning up our own bespoke json-based serialization routines.

I bring this up because there are still a bunch of pickles floating around the repository, notably in the testing modules, which themselves are just as susceptible to breaking (as happened recently with the changes made on PR #445). While it wasn't a big deal to update the pickle file in this one instance, I suspect we should be able to nix most instances of these in the codebase and substitute them with natively serialized equivalents. (Also, pickles are notoriously insecure and we probably should avoid having them in the repository as much as possible to begin with).

Not a high priority, but I wanted to bookmark this as something to work on the next time we take a dive into the testing infrastructure.

@coreyostrove coreyostrove added the enhancement Request for a new feature or a change to an existing feature label May 31, 2024
@sserita sserita added the low priority Developers should be aware of this issue, but it need not be addressed imminently label Sep 19, 2024
@sserita sserita modified the milestones: 0.9.14, 0.9.15+ Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a new feature or a change to an existing feature low priority Developers should be aware of this issue, but it need not be addressed imminently
Projects
None yet
Development

No branches or pull requests

2 participants