Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always english #18

Closed
PringlesKing opened this issue Mar 15, 2023 · 3 comments
Closed

Always english #18

PringlesKing opened this issue Mar 15, 2023 · 3 comments
Assignees
Labels
bug Something isn't working pending deployment

Comments

@PringlesKing
Copy link

When using .WithLanguageDetection() or .WithLanguage("auto") the language is always English auto-detected language: en (p = 0.515557) but if you specify the correct language then everything is fine

Other "port" and "bindings" libraries work fine and detect the language correctly

@sandrohanea
Copy link
Owner

Hello @PringlesKing,
It seems I introduced a bug in the underlying cpp library when using states (so it can be used in parallel).

Thanks for reporting the issue!

Fixed it in both places: ab26173 + ggerganov/whisper.cpp#627

Also, added the language on the segment data and a test for this case: 38d1bf3

Will wait a bit to see if the cpp PR gets merged soon, otherwise, I'll create a new version of whisper.net with my fork.

Also, will keep you posted when the newer version is available.

@sandrohanea sandrohanea added bug Something isn't working pending deployment labels Mar 18, 2023
@PringlesKing
Copy link
Author

PringlesKing commented Mar 19, 2023

There are more bugs here, for example, the temperature is inverted, at 0.9 it behaves like 0.1 for the OpenAI API.

if you specify .WithMaxTokensPerSegment(1) then there will be only one segment
also .SplitOnWord() doesn't work at all ¯\_(ツ)_/¯

and absolute silence cannot be detected by any tresholds

@sandrohanea
Copy link
Owner

The language problem was fixed, and the newer version was published on nuget: https://www.nuget.org/packages/Whisper.net/1.2.2
About the other problems, can you, please, check if you have them also with the cpp library?

If yes, a better report will be directly there, and we can take a look to see what's going on. If the issue is only reproducing on these bindings, please, report a new issue here with the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending deployment
Projects
None yet
Development

No branches or pull requests

2 participants