Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_pattern and other commands do not look like they can be mixed due to _init() #2

Open
kevinjwalters opened this issue Jun 14, 2018 · 0 comments
Open

set_pattern and other commands do not look like they can be mixed due to _init() #2

kevinjwalters opened this issue Jun 14, 2018 · 0 comments

Comments

@kevinjwalters
Copy link

set_pattern() calls _init(0) whereas the other commands call _init(1). I've only inspected this (haven't run the code) but the initialisation check on _bus variable in _init() looks like it prevents the i2c "led mode change command" being executed more than once? That would prevent mixing of set_pattern with other commands.

If this is a bug it can be fixed with some rejigging of activity inside _init(). If it was intentional then the behaviour/restriction could be documented perhaps?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinjwalters