Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically allocate memory to avoid stack overflow #227

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

puethe
Copy link
Contributor

@puethe puethe commented Jul 30, 2018

No description provided.

@puethe puethe merged commit e1df9fe into nickjcroucher:master Jul 30, 2018
@puethe puethe deleted the segfault branch July 30, 2018 15:30
@tseemann
Copy link

tseemann commented Aug 6, 2018

Nice catch! This could be where it was crashing for us in "diverse alignments" !

@puethe
Copy link
Contributor Author

puethe commented Aug 6, 2018

That's what we hope :) Would be great if you could, at some point, re-run gubbins with the data that let it crash and let us know about the outcome.

@tseemann
Copy link

tseemann commented Aug 7, 2018

It was run last night on a 435 x 6,000,000 alignment and finished successfully! 👍

I am surprised valgrind didn't find this, the original authors said they tried it. I'm assuming it was never tested on an alignment with so many SNPs, so never exceeded the stack size.

@puethe
Copy link
Contributor Author

puethe commented Aug 7, 2018

That's great, thanks for the feedback!

nickjcroucher pushed a commit that referenced this pull request Oct 6, 2021
dynamically allocate memory to avoid stack overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants