Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 3.0 #291

Merged
merged 246 commits into from
Jan 27, 2021
Merged

Upgrade to version 3.0 #291

merged 246 commits into from
Jan 27, 2021

Conversation

nickjcroucher
Copy link
Owner

Happy new year! Addresses most of the improvements discussed in #1. CI switched to Github Actions and currently passing all tests on Linux and OSX. Just restructuring of the code and packaging to address, which seems easier to deal with post-PR.

@degreesKelvin
Copy link

Happy new year! Addresses most of the improvements discussed in nickjcroucher#1. CI switched to Github Actions and currently passing all tests on Linux and OSX. Just restructuring of the code and packaging to address, which seems easier to deal with post-PR.

Hi @nickjcroucher, I have installed Gubbins in Ubuntu based on the instructions in the manual, but it is still in the 1.2.4 version and I encountered memory resource issues. Can you please provide the instructions on how I can upgrade to the latest version of Gubbins?

Thank you and Happy New Year!

Kind Regards,
Kelvin

@nickjcroucher
Copy link
Owner Author

Hi @degreesKelvin - I would not recommend using v3.0.0 yet, as we have not validated the accuracy of the results (coming soon hopefully!) - in the first instance, I would try installing the latest version available on conda (v2.4.1), which has some fixes to memory usage (it also uses marginal ancestral reconstruction, which may not be as accurate as the joint ancestral reconstruction in v1.2.4, but is likely to be faster and more memory efficient). If v2.4.1 doesn't work either, let me know - hopefully v3.0 will be ready for wider use soon!

@degreesKelvin
Copy link

degreesKelvin commented Jan 15, 2021 via email

python/gubbins/common.py Outdated Show resolved Hide resolved
python/gubbins/common.py Show resolved Hide resolved
@nickjcroucher
Copy link
Owner Author

Makefile removed in 2377005.

@nickjcroucher
Copy link
Owner Author

Further improvements suggested by @puethe:
• Makefile.in gone in 2377005
• Versions specified in yml in aa75c84
• Added missing dependencies to setup.py and environment.yml in d8be9e1
• Improved pyjar error message in 77883a8
• Changed menu options in 51f3c46

@puethe puethe merged commit dad074e into nickjcroucher:master Jan 27, 2021
nickjcroucher pushed a commit that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants