-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirtualList uses deprecated React method #2111
Comments
Not completely sure how it worked before, but adding new documents does not scroll to the new item. Could be related. The downstream dependency seems to be a zombie: clauderic/react-tiny-virtual-list#81 |
Still getting the same console warning for VirtualList with Sanity 2.14 and React 17.0.2 |
Hi! We are currently working on improving our workflows and follow-up on our open GitHub repository. In that work, we have decided to close most issues older than the release of Sanity Studio v3. We value your feedback, so if this issue is still important to you and relevant for Sanity Studio v3, please search for relevant open issues. If you can’t find any, open a new one and link to relevant comments in this thread. For questions about how to do something, please post them in the slack community. |
Describe the bug
react-tiny-virtual-list
implementcomponentWillReceiveProps
. It is used by InfiniteList.This emits a console warning when using Use React 17 with Sanity 2.0.9.
To Reproduce
Use React 17 with Sanity 2.0.9.
Open console:
Expected behavior
No warnings in browser console when starting Sanity using React 17.
Which versions of Sanity are you using?
@sanity/cli 2.0.9 (up to date)
@sanity/base 2.0.9 (up to date)
@sanity/block-content-to-react 2.0.7 (up to date)
@sanity/client 2.0.9 (up to date)
@sanity/components 2.0.9 (up to date)
@sanity/core 2.0.9 (up to date)
@sanity/dashboard 2.0.9 (up to date)
@sanity/default-layout 2.0.9 (up to date)
@sanity/default-login 2.0.9 (up to date)
@sanity/desk-tool 2.0.9 (up to date)
@sanity/form-builder 2.0.9 (up to date)
@sanity/production-preview 2.0.5 (up to date)
@sanity/vision 2.0.9 (up to date)
What operating system are you using?
Windows
Which versions of Node.js / npm are you running?
npm: 6.14.8
node: v14.15.0
Additional context
"react": "^17.0.1",
"react-dom": "^17.0.1"
The text was updated successfully, but these errors were encountered: