Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace maildev #420

Closed
groenroos opened this issue Feb 22, 2022 · 5 comments · Fixed by #442
Closed

Replace maildev #420

groenroos opened this issue Feb 22, 2022 · 5 comments · Fixed by #442
Assignees
Labels
help wanted Issues where help is needed from other contributors low priority Issues which should only be considered after everything else is done maintenance Keep dependencies, code and conventions fresh

Comments

@groenroos
Copy link
Member

We use maildev to test email capabilities in the Notifications lib.

However, the maildev package seems unmaintained, with multiple dependencies with security alerts, that have not been resolved or even acknowledged for over a year: maildev/maildev#352, maildev/maildev#356, maildev/maildev#359, maildev/maildev#362, maildev/maildev#374

While I don't think these security alerts will compromise using Sapling (as maildev is only a dev dependency for unit testing), I'm spending an outsize amount of time dealing with Dependabot security alerts and npm audits because of this.

Identify a suitable alternative for maildev, and refactor the Notifications test suite to eliminate the dependency.

@groenroos groenroos added maintenance Keep dependencies, code and conventions fresh low priority Issues which should only be considered after everything else is done help wanted Issues where help is needed from other contributors labels Feb 22, 2022
@groenroos groenroos self-assigned this Feb 22, 2022
@soulteary
Copy link

I agree with your views and opinions, because I also spent a long time sorting out and solving the problems in the old version of maildev.

But frankly speaking, there is no good choice at present, it is better to build the maildev v2.x version together.

btw: I came across this pr by searching, recently maildev updated a new version, I recommend you to use the new version @groenroos

@groenroos
Copy link
Member Author

@soulteary Thanks for reaching out, and for resurrecting maildev, it's great to see! ⭐️

I'm keen on upgrading to 2.x to avoid finding and implementing an alternative; however, it doesn't seem to be available on npm yet. Do you have an idea of when it will be?

@soulteary
Copy link

Don't mention it. @groenroos

I will keep reminding the npm maintainers to update the project's packages as soon as possible, but we have time difference, so it may take a day or two...

@groenroos
Copy link
Member Author

Alright - I (or at least Dependabot) will keep my eyes peeled! Thanks! 👍

@soulteary
Copy link

Hahaha I will sync your last situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues where help is needed from other contributors low priority Issues which should only be considered after everything else is done maintenance Keep dependencies, code and conventions fresh
Development

Successfully merging a pull request may close this issue.

2 participants