Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise encoding handling on Windows #16

Closed
uranusjr opened this issue Dec 15, 2018 · 2 comments
Closed

Revise encoding handling on Windows #16

uranusjr opened this issue Dec 15, 2018 · 2 comments
Assignees
@uranusjr
Labels
bug Something isn't working

Comments

@uranusjr
Copy link
Member

uranusjr commented Dec 15, 2018 •
edited
Loading

From pypa/pipenv#3382. Need to do something similar to #10: Try system encoding, and then utf-8, and replace unparsables.

Edit: No we don’t want to try UTF-8.
@uranusjr uranusjr changed the title Revise encoding handlign on Windows Revise encoding handling on Windows Dec 15, 2018
@uranusjr uranusjr self-assigned this Dec 15, 2018
@uranusjr uranusjr added the bug Something isn't working label Dec 15, 2018
@uranusjr uranusjr mentioned this issue Dec 15, 2018
Merged
@techalchemy
Copy link
Member

@uranusjr I literally just finished handling this problem I think I mentioned it in slack

@techalchemy
Copy link
Member

Let me read your thing and follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uranusjr uranusjr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uranusjr @techalchemy