Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusCode false negatives for more complex IfStmt #93

Closed
spencerschrock opened this issue Jun 4, 2024 · 0 comments · Fixed by #94
Closed

StatusCode false negatives for more complex IfStmt #93

spencerschrock opened this issue Jun 4, 2024 · 0 comments · Fixed by #94

Comments

@spencerschrock
Copy link
Contributor

The linter currently detects basic if statements:

if r.StatusCode == 404 {
	fmt.Println("not found")
}

But doesn't suggest status code replacements for more complicated expressions.

if false || r.StatusCode == 404 {
	fmt.Println("not found")
}

If you're accepting contributions, I'd be happy to send a fix and expand the test-httpstatus.go.tmpl template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant