Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all HTTP requests to @sasjs/adapter #1369

Open
YuryShkoda opened this issue Aug 15, 2023 · 0 comments
Open

Move all HTTP requests to @sasjs/adapter #1369

YuryShkoda opened this issue Aug 15, 2023 · 0 comments
Assignees
@YuryShkoda
Labels
adapter refactoring

Comments

@YuryShkoda
Copy link
Member

Problem

  • Currently @sasjs/cli and @sasjs/adapter use separate instances of axios which makes managing HTTP clients more difficult.
  • Verbose mode can't be enabled for the HTTP client used in @sasjs/cli.

To-do

  • Move logic from createFileFromUrl utility to @sasjs/adapter.
  • Move logic from isSasJsServerInServerMode utility to @sasjs/adapter.
  • Remove axios depency from @sasjs/cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuryShkoda YuryShkoda

Labels
adapter refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YuryShkoda