Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace ID with UID #363

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: replace ID with UID #363

wants to merge 6 commits into from

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented May 9, 2023

BREAKING CHANGE: remove auto incremental ids from user, group and permissions and add a virtual uid property that returns string value of documents object id

Issue

closes #361

Intent

replace ID with UID

Implementation

add a virtual property to models that returns string value of _id

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

sabhas added 4 commits May 9, 2023 15:01
@sabhas
feat: replace ID with UID
093fe90 
BREAKING CHANGE: remove auto incremental ids from user, group and permissions and add a virtual uid property that returns string value of documents object id
@sabhas
chore: specs fixed
6c88eea
@sabhas
chore: fix specs
3f815e9
@sabhas
chore: fix specs
8cdf605
@sabhas sabhas requested a review from YuryShkoda May 11, 2023 06:21
YuryShkoda
YuryShkoda reviewed Aug 8, 2023
View reviewed changes
web/src/utils/types.ts Outdated Show resolved Hide resolved
YuryShkoda
YuryShkoda reviewed Aug 8, 2023
View reviewed changes
web/src/utils/types.ts Outdated Show resolved Hide resolved
YuryShkoda
YuryShkoda reviewed Aug 8, 2023
View reviewed changes
web/src/utils/types.ts Outdated Show resolved Hide resolved
YuryShkoda
YuryShkoda requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@YuryShkoda YuryShkoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@sabhas sabhas requested a review from YuryShkoda August 8, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryShkoda YuryShkoda YuryShkoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace ID with UID
2 participants
@sabhas @YuryShkoda