From da4463be8235789bfb03cb45e1a78d178350fa9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=81=AA=E3=81=A4=E3=81=8D?= Date: Fri, 29 Dec 2023 19:24:27 -0800 Subject: [PATCH 1/2] Use implementation name dart-sass for VersionResponse --- lib/src/embedded/isolate_dispatcher.dart | 2 +- test/embedded/protocol_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/src/embedded/isolate_dispatcher.dart b/lib/src/embedded/isolate_dispatcher.dart index 018321cdd..b208cc6b3 100644 --- a/lib/src/embedded/isolate_dispatcher.dart +++ b/lib/src/embedded/isolate_dispatcher.dart @@ -137,7 +137,7 @@ class IsolateDispatcher { ..protocolVersion = const String.fromEnvironment("protocol-version") ..compilerVersion = const String.fromEnvironment("compiler-version") ..implementationVersion = const String.fromEnvironment("compiler-version") - ..implementationName = "Dart Sass"; + ..implementationName = "dart-sass"; } /// Handles an error thrown by the dispatcher or code it dispatches to. diff --git a/test/embedded/protocol_test.dart b/test/embedded/protocol_test.dart index 9e293365e..b77d376e0 100644 --- a/test/embedded/protocol_test.dart +++ b/test/embedded/protocol_test.dart @@ -96,7 +96,7 @@ void main() { Version.parse(response.protocolVersion); // shouldn't throw Version.parse(response.compilerVersion); // shouldn't throw Version.parse(response.implementationVersion); // shouldn't throw - expect(response.implementationName, equals("Dart Sass")); + expect(response.implementationName, equals("dart-sass")); await process.close(); }); From f387090167bf0f93d83cf52f29f59f3aa92dc363 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Tue, 2 Jan 2024 16:47:47 -0800 Subject: [PATCH 2/2] Update pubspec and changelog --- CHANGELOG.md | 7 +++++++ pubspec.yaml | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a7884687c..5cb089502 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## 1.69.8 + +### Embedded Sass + +* The Dart Sass embedded compiler now reports its name as "dart-sass" rather + than "Dart Sass", to match the JS API's `info` field. + ## 1.69.7 ### Embedded Sass diff --git a/pubspec.yaml b/pubspec.yaml index 013259037..2722f7bcc 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: sass -version: 1.69.7 +version: 1.69.8-dev description: A Sass implementation in Dart. homepage: https://github.com/sass/dart-sass