From 57c6f497a0143ef0311786994b3133b9f367b676 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=81=AA=E3=81=A4=E3=81=8D?= Date: Wed, 10 Jan 2024 11:04:09 -0800 Subject: [PATCH 1/2] Support CompileRequest.silent of embedded protocol --- lib/src/embedded/compilation_dispatcher.dart | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/src/embedded/compilation_dispatcher.dart b/lib/src/embedded/compilation_dispatcher.dart index 218ea6f18..4e390fcd9 100644 --- a/lib/src/embedded/compilation_dispatcher.dart +++ b/lib/src/embedded/compilation_dispatcher.dart @@ -12,6 +12,7 @@ import 'package:path/path.dart' as p; import 'package:protobuf/protobuf.dart'; import 'package:sass/sass.dart' as sass; +import '../logger.dart'; import '../value/function.dart'; import '../value/mixin.dart'; import 'embedded_sass.pb.dart'; @@ -117,8 +118,10 @@ final class CompilationDispatcher { var style = request.style == OutputStyle.COMPRESSED ? sass.OutputStyle.compressed : sass.OutputStyle.expanded; - var logger = EmbeddedLogger(this, - color: request.alertColor, ascii: request.alertAscii); + var logger = request.silent + ? Logger.quiet + : EmbeddedLogger(this, + color: request.alertColor, ascii: request.alertAscii); try { var importers = request.importers.map((importer) => From f8bf5bd7066310ad84c6f4b104b63fd86c5742d1 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Tue, 16 Jan 2024 14:48:01 -0800 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5cb089502..90117468e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ### Embedded Sass +* Support the `CompileRequest.silent` field. This allows compilations with no + logging to avoid unnecessary request/response cycles. + * The Dart Sass embedded compiler now reports its name as "dart-sass" rather than "Dart Sass", to match the JS API's `info` field.