crash with invalid @warn input in Visual Studio

[hmoffatt]

Similar to #1443 that I reported regarding a crash calling rbga with invalid parameters when compiled with VS, I find that

@warn foo!;

causes a crash in the same place (Memory_Manager::destroy(T* np)).

[drewwells]

Are you seeing crashes for errors too? Invalid input ie div { is throwing errors for me

[hmoffatt]

Hmm, no just "div {" as input does not cause a crash for me.

[mgreter]

I can reproduce this issue and also confirm that #1462 fixes it. @hmoffatt can you compile from source and confirm? I will re-try once I re-base after the PRs got merged ...

[hmoffatt]

Try master now?

[mgreter]

mgreter:bugfix/msvc-memory-manager

[hmoffatt]

Yes that works for me.

[hmoffatt]

It's probably not new, but when I compile the sassc vcxproj I am getting these warnings from sass_context.cpp:

1>c:\dev\test\libsass\src\sass_context.cpp(193): warning C4297: 'copy_strings' : function assumed not to throw an exception but does
1> The function is extern "C" and /EHc was specified
1>c:\dev\test\libsass\src\sass_context.cpp(197): warning C4297: 'copy_strings' : function assumed not to throw an exception but does
1> The function is extern "C" and /EHc was specified

[mgreter]

Yes that works for me.

👍