Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Importer caching bug? #1638

Closed
chriseppstein opened this issue Oct 26, 2015 · 1 comment · Fixed by #1626
Closed

Custom Importer caching bug? #1638

chriseppstein opened this issue Oct 26, 2015 · 1 comment · Fixed by #1626

Comments

@chriseppstein
Copy link
Contributor

In Eyeglass we have an importOnce facility to avoid processing sass files that are imported many times during the same css file output.

It seems like caching is based on the import URI instead of the filename returned by the custom importer.

This can be reproduced by running the tests in eyeglass on the node-sass-3-4 branch. The only failing test case is the importOnce test.

Note: This is fixed by #1626 though a smaller point fix could also be made.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 27, 2015

Thanks for the report @chriseppstein

This can be reproduced by running the tests in eyeglass on the node-sass-3-4 branch

Thank you for this!

This is fixed by #1626 though a smaller point fix could also be made

I'm keen to get this out in 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants