Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @supports in combination with %placeholders can leave placeholder names in compiled css file #1994

Closed
mkstix6 opened this issue Apr 13, 2016 · 1 comment

Comments

@mkstix6
Copy link

mkstix6 commented Apr 13, 2016

%hoverbrighter {
    &:hover,
    &:focus {
        opacity: .8;

        @supports (filter: brightness(120%)) {
            filter: brightness(120%);
        }
    }
}

.productportal-link {
    @extend %hoverbrighter;
}

--- can compile to ---

.productportal-link:hover, .productportal-link:focus {
  opacity: .8;
}

@supports (filter: brightness(120%)) {
  %hoverbrighter:hover, .productportal-link:hover, %hoverbrighter:focus, .productportal-link:focus {
    filter: brightness(120%);
  }
}

I don't think the %hoverbrighter should be there in the compiled result.

On SassMeister the result is as I would expect http://www.sassmeister.com/gist/cd5494dd2f57ccf90b48a87c862c8f6f.

@mgreter
Copy link
Contributor

mgreter commented Apr 15, 2016

This seems to be fixed on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants