Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling hangs when selectors with ">" are present #3013

Closed
massimo-cassandro opened this issue Oct 22, 2019 · 5 comments
Closed

Compiling hangs when selectors with ">" are present #3013

massimo-cassandro opened this issue Oct 22, 2019 · 5 comments

Comments

@massimo-cassandro
Copy link

Compiling scss files hangs in presence of selectors that contain the ">" character. (version 3.6.2)

Example:

this rules hang while compiling:

// 1
.buttons > div {
  //some rules

  > button { 
    //some rules
  }
}

// 2
label {
  > div {
    // some rules

    &:nth-child(1) {
      // some rules
    }
  }
}

All works well if rewritten in this way:

// 1
.buttons > div {
  //some rules
}

.buttons > div > button { 
  //some rules
 }

// 2
label {
  > div {
    // some rules
  }
}
label > div:nth-child(1) {
     // some rules
}

Expected css:

// 1
.buttons > div { ... }
.buttons > div > button { ... }

// 2
label > div { ... }
label > div:nth-child(1) { ... }
@bdkjones
Copy link

I can’t confirm the exact cause, but I can confirm that I’ve had a flood of “sass compiling just hangs” reports since I shipped 3.6.2. I am rolling back to 3.6.1 for the time being.

@mgreter
Copy link
Contributor

mgreter commented Oct 23, 2019

This seems to be the same issue as already reported.
Looks like already fixed either by #3007 or #2995.

I can't seem to reproduce this with 3.6.2

@mgreter
Copy link
Contributor

mgreter commented Oct 23, 2019

Sorry for the inconvenience @bdkjones, too bad the specs did not catch it before.
Will probably release 3.6.3 in some days if nothing else critical is reported.

@mgreter
Copy link
Contributor

mgreter commented Oct 23, 2019

Please re-open if you can reproduce this with 3.6.2, thanks.

@mgreter mgreter closed this as completed Oct 23, 2019
@bdkjones
Copy link

@mgreter no worries; I ship bugs all the time. It happens. This report is from one of my users and he was definitely running 3.6.2 at the time. I didn’t try to reproduce it myself, but I did have many other reports of hung compiling with 3.6.2, so I just assumed there was a regression somewhere.

All of my Sass test files compiled correctly before I shipped the update with Libsass 3.6.2 in it, so the hang only manifests in certain conditions. I’ll wait for 3.6.3 and see if that resolves it.

@massimo-cassandro: can you please email me the original Sass files that were hanging the compiler? I need ALL of them—the main file and everything it imports. That way, I can test Libsass 3.6.3 when it’s ready. My existing Sass test files clearly don’t trigger this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants