Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for in-place importing of CSS #318

Closed
jacobsvante opened this issue Mar 16, 2014 · 7 comments
Closed

Support for in-place importing of CSS #318

jacobsvante opened this issue Mar 16, 2014 · 7 comments

Comments

@jacobsvante
Copy link

jacobsvante commented Mar 16, 2014

This is currently possible with the Ruby version using https://github.com/chriseppstein/sass-css-importer. Would be great to have so we can import CSS from bower libs etc.

pirelenito added a commit to saguijs/sagui that referenced this issue Mar 16, 2014
Natively SCSS doesn't support in-place importing of CSS files ( sass/libsass#318 ), but we want to import bower dependencies CSS files into our SCSS files.

The temporary solution ( as suggested by sass/sass#556 (comment) ) is to copy all the CSS files at the bower_components folder as SCSS files so that we can import them.

The implemented solution also uses a watch to perform this copy task automatically on any dependency changes.
@bdkjones
Copy link

bdkjones commented Apr 4, 2014

+1 for this.

It's been officially roadmapped for Sass 3.4 (along with a complete overhaul of the @import routines), but I can tell you from my email that the ability to import straight CSS is highly desired.

@nathanhammond
Copy link

The full collection of use cases for people who stumble across this is documented here: sass/sass#1094

mgreter added a commit to mgreter/libsass that referenced this issue Dec 22, 2014
sass#318
Refactor lookup code for better readability
@mgreter
Copy link
Contributor

mgreter commented Dec 22, 2014

What's the status on this? If I'm correct we can implement to load css files at least with non-standard imports, like @import "file";? This would not touch the way how @import url("file.css"); would be handled. Therefore people at least could use it in this way to include raw css files.

@bdkjones
Copy link

Well, both @import "file.css" and @import url("file.css") are part of the actual CSS spec and, as such, should be left intact. That is, making one of these inline the contents of the CSS file would go against the spec. What is needed is a formal syntax to inline CSS, similar to what Less does. That's the right way to handle the issue.

Sent from my iPhone

On Dec 22, 2014, at 11:28, Marcel Greter notifications@github.com wrote:

What's the status on this? If I'm correct we can implement to load css files at least with non-standard imports, like @import "file";? This would not touch the way how @import url("file.css"); would be handled. Therefore people at least could use it in this way to include raw css files.


Reply to this email directly or view it on GitHub.

@mgreter
Copy link
Contributor

mgreter commented Dec 22, 2014

OK, so PR at #754 should be good to go!?

mgreter added a commit to mgreter/libsass that referenced this issue Dec 26, 2014
sass#318
Refactor lookup code for better readability
mgreter added a commit to mgreter/libsass that referenced this issue Dec 27, 2014
sass#318
Refactor lookup code for better readability
mgreter added a commit to mgreter/libsass that referenced this issue Jan 2, 2015
sass#318
Refactor lookup code for better readability
@mgreter
Copy link
Contributor

mgreter commented Jan 3, 2015

#754 has been merged!

@mgreter mgreter closed this as completed Jan 3, 2015
@xzyfer xzyfer modified the milestone: 3.2 Jan 3, 2015
@josephspens
Copy link

Do we know what version this will be available?

Never mind, I see the 3.2 milestone on the PR itself. I wantz it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants