Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing request package #2622

Closed
SimonSchick opened this issue Apr 2, 2019 · 1 comment
Closed

Consider replacing request package #2622

SimonSchick opened this issue Apr 2, 2019 · 1 comment

Comments

@SimonSchick
Copy link

You might want to consider replacing request as it is entering maintenance mode.
request/request#3142
request/request#3143

After a first look it should be relatively easy to replace request with the built-in http/https library as you are only using a tiny subset of its features.
@nschonni
Copy link
Contributor

Request is used by node-gyp as well so replacing it wouldn't really remove the subdependncy. We tried other packages in the past, but request still has the best support for Proxies, which is needed for many consumers

Friendly-users referenced this issue in Friendly-users/node-sass Jul 9, 2024
@Friendly-users
No politics or offense in public code.
75139ea 
-----
It is inappropriate to include political and offensive content in public code repositories.

Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment.

Please refrain from adding such content to public code repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nschonni @SimonSchick