This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saper
force-pushed
the
node-modules-79
branch
2 times, most recently
from
October 22, 2019 18:37
417ef1b
to
4f6412c
Compare
fitztrev
reviewed
Oct 22, 2019
saper
force-pushed
the
node-modules-79
branch
2 times, most recently
from
October 22, 2019 19:47
3eed4fd
to
85be26c
Compare
https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/ |
saper
force-pushed
the
node-modules-79
branch
from
October 22, 2019 21:13
85be26c
to
64b6f32
Compare
xzyfer
approved these changes
Oct 22, 2019
3 tasks
saper
commented
Oct 23, 2019
|
||
before_install: | ||
- echo $TRAVIS_NODE_VERSION | ||
- npm config set python `which python` | ||
- if [ $TRAVIS_OS_NAME == "linux" ]; then | ||
if [[ $(node -v) =~ v[1-9][0-9] ]]; then | ||
if [[ $(node -v) =~ v13 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to BUILDING.md we should be using gcc 6 also for node 12... II think we should change this
This was referenced Mar 27, 2020
This was referenced Apr 15, 2020
This was referenced Mar 6, 2021
Closed
This was referenced Mar 12, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.