This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Upgrade NAN to 1.2.0 #350

Closed

andrew opened this issue Jun 12, 2014 · 0 comments · Fixed by #353

Labels

Community - Help Wanted

Milestone

Contributor

andrew commented Jun 12, 2014

While you're at it, upgrade to NAN 1.2.0 and replace all of the NanSymbol() calls with NanNew() as the former has been deprecated because it's been removed from V8 completely and not coming back in any form.

As per @rvagg's comment on #337 (comment)

andrew added the help wanted label

andrew added this to the v0.10.0 milestone

andrew mentioned this issue

Updated to NAN 1.2.0 and switched NanSymbol to NanNew #353

Merged

andrew closed this as completed in #353

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.