v5 Electron Support (5-8) #2872

glenn2223 · 2020-03-23T00:54:17Z

Adding support for electron v5-8. PR'ing to v5 due to node-gyp bump

Bringing support for Electron 5, 6, 7 & 8 (windows x32 & x64 only) Looking to expand to all other platforms but can't myself. See https://github.com/sass/node-sass/tree/master/.github/Electron-support.md

Added doc to explain steps required for electron support

Reverted isSupportedEnvironment back to it's original state and removed the function for detecting current electron support

But mor ereading and we can do it without electron-rebuild

Targeted electron versions to stop fails Added artifacts for testing

For electron building

Need to replace electron version with underlying node shown in a comment after each version number

Added new workflows and updated windows version

Oops

Windows ignorance and plain idiocy

Skipping npm test as they always fail Removed artifacts for .pdb on linus and osx Added extra step for ia32 linux

Added support for forcing an electron build by adding an argument

Updated workflows for tests

Forgot the node-gyp bump

…into Electron-Test

saper · 2020-03-23T11:52:10Z

Thank you @glenn2223 for your patience! I'll check if my build machinery can build node-sass for electron as well.

glenn2223 · 2020-03-23T12:34:18Z

Ref: Commit Fix: Extensions don't honour argument arch

Test 1: Step 5: Line 4 setting arch as ia32, Step 5: Line 447 save path uses x64
Test 2: Success

Thanks @saper

nschonni

This seems to have a lot more random formatting churn and changes to the overall build setup than the last PR. What has changed that required this?

.github/workflows/electron-linux.yml

glenn2223 · 2020-04-11T06:25:36Z

This seems to have a lot more random formatting churn and changes to the overall build setup than the last PR. What has changed that required this?

Formatting:
Sorry I was working on another project at the same time so I just automatically hit my format shortcut. I can revert this if you wish?
Fix: (Fix: Extensions don't honour argument target-arch)
Did you want this on another PR for this?
Electron targeting:
I wasn't able to find a way to run electron commands (for each version) from the CI so I added a --electron-version argument. This added a function and expanded a couple of lines that I've added. This also has the added benefit of targeting an electron build without electron

Spelling correction Workflow update Reverted stdio (sorry, was trying to see if I could get a clearer error for an issue I was facing)

glenn2223 added 30 commits March 16, 2020 18:13

Support upto Electron 8 (Windows ONLY)

f57f4b4

Bringing support for Electron 5, 6, 7 & 8 (windows x32 & x64 only) Looking to expand to all other platforms but can't myself. See https://github.com/sass/node-sass/tree/master/.github/Electron-support.md

Docs to expand on Electron Support

9c5aeb6

Added doc to explain steps required for electron support

Update Electron-Support.md

7f5b6bf

Update Electron-Support.md

90e697d

Reverted isSupportedEnvironment

e6b1a43

Reverted isSupportedEnvironment back to it's original state and removed the function for detecting current electron support

Create electron-win.yml

0661d3b

Delete Electron-Support.md

92b7ef0

But mor ereading and we can do it without electron-rebuild

Removed bindings

1760a4c

Merge branch 'master' of https://github.com/glenn2223/node-sass

ed1c343

Update electron-win.yml

97a903b

Targeted electron versions to stop fails Added artifacts for testing

Updated node-gyp to 6.1.0

2bc2261

For electron building

Renamed artifacts to almost match

5fe05fa

Need to replace electron version with underlying node shown in a comment after each version number

Workflow changes

80a5070

Added new workflows and updated windows version

Update electron-linux.yml

7368214

Workflow updates

f3aaea6

Oops

Workflow updates

18687aa

Windows ignorance and plain idiocy

Workflow updates

499e066

Fixes

9642e7b

Skipping npm test as they always fail Removed artifacts for .pdb on linus and osx Added extra step for ia32 linux

Update electron-linux.yml

d95fc8a

Update electron-linux.yml

9d01660

Update electron-linux.yml

69ddf4c

Update electron-linux.yml

2cc27f0

Update electron-linux.yml

480890d

Update electron-linux.yml

72ed801

Dropped x32 from linux workflow

138d277

Reverted to electron rebuild

165f68a

Merge branch 'master' of https://github.com/glenn2223/node-sass

2eb370e

Update electron-win.yml

ed333ad

Update workflows

4da3d46

Workflow updates

17cfbc0

glenn2223 added 8 commits March 21, 2020 00:47

Update build.js

2ecdd2a

Update build.js

0e74f76

Optional forcing of electron build

6eeedea

Added support for forcing an electron build by adding an argument

Updated workflows

712d495

Updated workflows for tests

Updated lingering console log

d51123f

Updated workflows

f17457b

node-gyp bump

5c83ff1

Forgot the node-gyp bump

Workflow updates

6c30086

glenn2223 mentioned this pull request Mar 23, 2020

Support up to Electron 8 #2862

Closed

glenn2223 added 7 commits March 23, 2020 08:53

Resolving PR dependancies

e173f61

Removed duplication of --arch

963b83e

Added Windows --arch targeting

be34ce5

Merge branch 'v5' into Electron-Test

4f9ccc0

Fix: Extensions don't honor argment arch

7552f4e

Merge branch 'Electron-Test' of https://github.com/glenn2223/node-sass …

a5abeed

…into Electron-Test

Double quote fix

92eca82

glenn2223 added 2 commits March 23, 2020 12:27

Updated windows workflow

3289bbd

Travis fixes

9f40bf7

Merge branch 'v5' into Electron-Test

a536530

nschonni reviewed Apr 10, 2020

View reviewed changes

.github/workflows/electron-linux.yml Outdated Show resolved Hide resolved

glenn2223 added 7 commits April 11, 2020 07:27

Small revision

3216467

Spelling correction Workflow update Reverted stdio (sorry, was trying to see if I could get a clearer error for an issue I was facing)

Update electron-linux.yml

b616802

Update electron-osx.yml

7abdec3

Update electron-linux.yml

d9e3870

Update electron-win.yml

a34d22b

Update yml

0a905c5

Update extensions.js

7fa8d75

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5 Electron Support (5-8) #2872

v5 Electron Support (5-8) #2872

glenn2223 commented Mar 23, 2020

saper commented Mar 23, 2020

glenn2223 commented Mar 23, 2020 •

edited

Loading

nschonni left a comment

glenn2223 commented Apr 11, 2020

v5 Electron Support (5-8) #2872

Are you sure you want to change the base?

v5 Electron Support (5-8) #2872

Conversation

glenn2223 commented Mar 23, 2020

saper commented Mar 23, 2020

glenn2223 commented Mar 23, 2020 • edited Loading

nschonni left a comment

Choose a reason for hiding this comment

glenn2223 commented Apr 11, 2020

glenn2223 commented Mar 23, 2020 •

edited

Loading