Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SourceMap tests #920

Closed
nschonni opened this issue Sep 14, 2016 · 4 comments
Closed

Include SourceMap tests #920

nschonni opened this issue Sep 14, 2016 · 4 comments

Comments

@nschonni
Copy link
Contributor

I was looking at the cleaning up the node-sass test suite, but realized we need to keep our sourcemap tests right now.
What do you think of including sourcemaps for the expected.css? Also maybe some option.yml frontmatter to cover the other sourcemap options (inline, relative, etc..)?

@xzyfer
Copy link
Contributor

xzyfer commented Sep 14, 2016

We have some issues in LibSass with regards to sourcemap being different. We have some hacks targeted at making Chrome behaviour. No browser follows the full sourcemaps spec, current implementations are varying degrees of under baked.

Sass spec has a very limited scope. It's job is to assert the semantic equality of output CSS of different engines. Currently we do exact output + some normalisation. This is just because there isn't a good prebuilt library for assert semantic equality of CSS.

This is also the reason we've recently moved output style spec off to the side. The insignificant whitespace in output styles doesn't affect semantic equality.

For this reason I don't think it's reasonable to expect implementations to agree on sourcemaps. IMHO this is out of scope for sass spec in the same way output formats are.

@nschonni
Copy link
Contributor Author

We have some issues in LibSass with regards to sourcemap being different.

This should be fixed if sass/sass#2150 and sass/libsass#2193 land.

@xzyfer
Copy link
Contributor

xzyfer commented Sep 27, 2016

I don't believe that's true. The sourcemaps generated by LibSass are structurally different mapping. I'm still of the opinion this does not belong in sass spec.

@nex3
Copy link
Contributor

nex3 commented Jun 8, 2022

I agree with @xzyfer. How each implementation handles source maps is up to that implementation, and not something that should be mandated by sass-spec.

@nex3 nex3 closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants