Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapQuery unable to exit when wrong input is inputted #5373

Closed
Chengwei94 opened this issue Dec 8, 2021 · 4 comments
Closed

MapQuery unable to exit when wrong input is inputted #5373

Chengwei94 opened this issue Dec 8, 2021 · 4 comments
Labels
more-information-needed We need more information before this can be addressed

Comments

@Chengwei94
Copy link

When using the mapquery function with wrong inputs such as not returning umap model in the previous step or putting the wrong columns in the refdata variable, the function just shows the error and the function get stuck there, instead of ending the function. I have to kill my R process everytime to exit.

@Chengwei94 Chengwei94 added the bug Something isn't working label Dec 8, 2021
@torkencz
Copy link
Collaborator

Can you provide more information on the session you are running and maybe the code as well.

@torkencz torkencz added the more-information-needed We need more information before this can be addressed label Dec 10, 2021
@yuhanH yuhanH removed the bug Something isn't working label Dec 10, 2021
@yuhanH
Copy link
Collaborator

yuhanH commented Dec 10, 2021

We also notice that if you put wrong input into MapQuery, it will be ending normally. We are working on it.

@yuhanH yuhanH self-assigned this Dec 10, 2021
@yuhanH
Copy link
Collaborator

yuhanH commented Dec 16, 2021

hi @Chengwei94
In the latest version seurat (4.0.6), when you put wrong input, MapQuery should just return the error info.

@yuhanH yuhanH removed their assignment Dec 16, 2021
@no-response
Copy link

no-response bot commented Dec 24, 2021

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed We need more information before this can be addressed
Projects
None yet
Development

No branches or pull requests

3 participants