Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

fix: moved color to last prop #1105

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

adamsythe
Copy link
Contributor

Motivation

For tabbar labels I want to add styles and either active or inactive color. The assumption is that the color prop would override the style prop.

Copy link
Owner

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164 satya164 merged commit b6eec35 into satya164:main Mar 6, 2021
@kamui545
Copy link

kamui545 commented Mar 11, 2021

Not sure if it was really the "recommended" way to use it, but this will break for people using <TabBar labelStyle={{ color: 'black' }} />.

You now have to set both activeColor and inactiveColor, which I don't mind at all, just letting people know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants