Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Forward button does not work when $wait timeout is fired #12

Open
saurabhdaware opened this issue Mar 13, 2020 · 0 comments
Open

Forward button does not work when $wait timeout is fired #12

saurabhdaware opened this issue Mar 13, 2020 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed v1.0.0 Will be part of v1.0.0
Milestone

Comments

@saurabhdaware
Copy link
Owner

Steps to reproduce

  • Create a talk with $wait10s somewhere in the transcript.
  • When 10 seconds pause is fired, try pressing forward button or backward button

Expected Behavior

  • When Forward or Backward is pressed, the timeout should be canceled.

Problem?

when the talk discovers $wait10s it calls a function await wait(10000) which is promisified version of setTimeout (the function is defined in scripts/helpers.js). When it fires it waits for the promise to resolve to continue. Meanwhile, if you press forward it will go forward but after promise is resolved it will go back to the previous slide.

@saurabhdaware saurabhdaware added bug Something isn't working help wanted Extra attention is needed v1.0.0 Will be part of v1.0.0 labels Mar 13, 2020
@saurabhdaware saurabhdaware added this to the v1.0.0-beta milestone Mar 13, 2020
@saurabhdaware saurabhdaware pinned this issue Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed v1.0.0 Will be part of v1.0.0
Projects
None yet
Development

No branches or pull requests

1 participant