Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nativefiledialog as submodule #2

Closed
3 tasks done
therustmonk opened this issue Aug 15, 2016 · 3 comments
Closed
3 tasks done

nativefiledialog as submodule #2

therustmonk opened this issue Aug 15, 2016 · 3 comments

Comments

@therustmonk
Copy link
Contributor

therustmonk commented Aug 15, 2016

PR mlabbe/nativefiledialog#19 was merged. It makes possible to use it as submodule.

@saurvs @emoon Let's consider to use it mentioned way.

Now nativefiledialog (devel branch) uses premake 5 and have Makefiles to popular OS. I offer:

  • Use nativefiledialog as git submodule
  • Remove nfd folder with local version (and stop to maintain it)
  • Update and still use build.rs script

Any ideas? Caveats?

@emoon
Copy link
Contributor

emoon commented Aug 15, 2016

That sounds fine. I very much prefer that we use build.rs as it allows Rust users to use the library without needing external build tools.

@therustmonk
Copy link
Contributor Author

I've made a PR #3 to fix it.

@therustmonk
Copy link
Contributor Author

It was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants